Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Conditional Requests #24

Merged
merged 4 commits into from
Aug 14, 2020
Merged

Implement Conditional Requests #24

merged 4 commits into from
Aug 14, 2020

Conversation

luxas
Copy link
Collaborator

@luxas luxas commented Aug 13, 2020

Fixes: #23
cc @twelho @yiannistri @martina-if please review

@luxas luxas added this to the v0.0.1 milestone Aug 13, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #24 into master will increase coverage by 1.29%.
The diff coverage is 71.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   53.57%   54.86%   +1.29%     
==========================================
  Files          22       22              
  Lines        1034     1068      +34     
==========================================
+ Hits          554      586      +32     
+ Misses        450      447       -3     
- Partials       30       35       +5     
Impacted Files Coverage Δ
github/client_organizations.go 71.42% <ø> (ø)
github/auth.go 57.27% <71.15%> (+16.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2a7a6...6f3e527. Read the comment docs.

Copy link

@twelho twelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@luxas luxas merged commit e566b19 into master Aug 14, 2020
@luxas luxas deleted the cache_transport branch August 14, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use conditional requests for GitHub
4 participants