Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update logr to 1.2.4 and fix Stash client #210

Merged
merged 1 commit into from
Apr 20, 2023
Merged

update logr to 1.2.4 and fix Stash client #210

merged 1 commit into from
Apr 20, 2023

Commits on Apr 19, 2023

  1. update logr to 1.2.4 and fix Stash client 

    In version 1.2.4 a [change](go-logr/logr#166)
was introduced that significantly changed the assumptions about logr's
API, i.e. that `logr.Logger{} != logr.Discard()`. This condition
doesn't evaluate to true with 1.2.4, anymore, and the default value of
the `logr.Logger` type is now usable as a replacement for
`logr.Discard()`.

Therefore we do not need to check if the value has been provided,
anymore: If it is not provided, the default one is used which is
effectively a discarding logger.

closes #209

Signed-off-by: Max Jonas Werner <[email protected]>
    Max Jonas Werner committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    4d35975 View commit details
    Browse the repository at this point in the history