Various cleanup fixes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 52.86% 53.57% +0.71%
==========================================
Files 21 22 +1
Lines 978 1034 +56
==========================================
+ Hits 517 554 +37
- Misses 429 450 +21
+ Partials 32 30 -2
Continue to review full report at Codecov.
|
…led linters later.
…le, and unit-test this.
…method to compare info objects
|
@twelho @stefanprodan ready for review & merge 😄 |
twelho
reviewed
Aug 13, 2020
| @@ -223,6 +224,7 @@ func NewClient(ctx context.Context, optFns ...ClientOption) (gitprovider.Client, | |||
| // the default. | |||
| var gh *github.Client | |||
| var domain string | |||
|
|
|||
There was a problem hiding this comment.
I started adding all these spaces because of the whitespace linter wsl, but then was just like "nah, I don't care" and left half-way through 😂
I think I'll live things as-is now, and someone can later make whitespace consistent across the project.
Low-hanging fruit anyways.
bitbucket/doc.go
Outdated
| @@ -17,5 +17,6 @@ limitations under the License. | |||
| package bitbucket | |||
|
|
|||
| import ( | |||
| // Dummy import until we have the implementation ready. | |||
.golangci.yml
Outdated
| # - godox don't error although there are TODOs in the code | ||
| - funlen | ||
| - whitespace | ||
| # - wsl allow "non-ideomatic" whitespace formattings for now |
| @@ -99,6 +103,7 @@ func (c *TeamsClient) List(ctx context.Context) ([]gitprovider.Team, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| @@ -73,6 +74,7 @@ func (c *OrganizationsClient) List(ctx context.Context) ([]gitprovider.Organizat | |||
| if apiObj.Login == nil { | |||
| return nil, fmt.Errorf("didn't expect login to be nil for org: %+v: %w", apiObj, gitprovider.ErrInvalidServerData) | |||
| } | |||
|
|
|||
github/resource_repository.go
Outdated
| return false, nil | ||
| } | ||
| // Otherwise, make the desired state the actual state | ||
| return true, r.Update(ctx) | ||
| } | ||
|
|
||
| // Delete deletes the current resource irreversebly. | ||
| // Delete deletes the current resource irreversible. |
There was a problem hiding this comment.
heh I just changed this based on the linter's suggestion without even looking at it 😂
gitlab/doc.go
Outdated
| @@ -17,5 +17,6 @@ limitations under the License. | |||
| package gitlab | |||
|
|
|||
| import ( | |||
| // Dummy import until we have the implementation ready. | |||
gitprovider/gitprovider.go
Outdated
| type GenericDeletable interface { | ||
| // Delete deletes the current resource irreversebly. | ||
| type Deletable interface { | ||
| // Delete deletes the current resource irreversible. |
|
Addressed comments, ready to merge. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
CreatableInfointo the more descriptiveInfoRequestandDefaultedInfoRequest, which*Infostructs should implement