Add ACR auth to Image Updates examples #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealthybox
force-pushed
the
integrations-registry-credentials-sync
branch
from
ac48ab7 to
2e4585d
Compare
stefanprodan
reviewed
Feb 8, 2021
stealthybox
force-pushed
the
integrations-registry-credentials-sync
branch
from
2e4585d to
959f499
Compare
stealthybox
commented
Feb 8, 2021
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| resources: | ||
| - https://github.com/fluxcd/flux2/archive/main.zip//manifests/integrations/registry-credentials-sync/azure |
There was a problem hiding this comment.
Updated to zip archive @ main.
We don't have a stable tag that denotes the latest release -- that could be useful in the future.
Comment on lines
+861
to
+862
| This example uses the `fluxcd/flux2` github archive as a remote base, but you may copy the [./manifests/integrations/registry-credentials-sync/azure](github.com/fluxcd/flux2/tree/main/manifests/integrations/registry-credentials-sync/azure) | ||
| folder into your own repository or use a git submodule to vendor it if preferred. |
There was a problem hiding this comment.
Updated this link -- I realized it was broken before
stealthybox
changed the title
stefanprodan
approved these changes
Feb 8, 2021
Signed-off-by: leigh capili <[email protected]>
Signed-off-by: leigh capili <[email protected]>
stealthybox
force-pushed
the
integrations-registry-credentials-sync
branch
from
959f499 to
e99b1c3
Compare
stefanprodan
added
area/docs
29 tasks
3 tasks
6 tasks
ybelleguic
pushed a commit
to ybelleguic/flux2
that referenced
this pull request
Jan 9, 2023
Release v0.28.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS/GCP/Azure all had similar approaches so I factored the 3 approaches onto
a single kustomize base for a Deployment and CronJob option.
The cloud specific reconcile() shell functions are interpolated into the command
array using the Pod API so that we can patch it separately from any shell library funcs.
The KUBE_SECRET is user configurable, and as long as they are using kustomize,
it's updated on the Role as the only allowed resourceName, so that the RBAC is safer.
A similar vars trick is used to keep the AAD Pod label in sync.
The documented example uses a remote base since kustomize does not have a standard vendoring approach.
I can update the GCP and AWS examples to reference kustomize in a follow-up.