Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding --select-alpha and --extract to create image policy #860

Merged
merged 4 commits into from
Feb 9, 2021
Merged

Adding --select-alpha and --extract to create image policy #860

merged 4 commits into from
Feb 9, 2021

Conversation

jonathan-innis
Copy link
Contributor

Closes #822

@hiddeco hiddeco requested a review from squaremo February 4, 2021 09:11
@hiddeco hiddeco added area/UX enhancement New feature or request labels Feb 4, 2021
squaremo
squaremo requested changes Feb 4, 2021
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat and tidy, thanks Jonathan 🍏 I'm always happy to see concise commit messages too :-)
One minor request (also in a comment): could it check that the user didn't supply both semver and alpha, please.

cmd/flux/create_image_policy.go Show resolved Hide resolved
cmd/flux/create_image_policy.go Show resolved Hide resolved
@stefanprodan stefanprodan added the area/image-automation Automated image updates related issues and pull requests label Feb 4, 2021
@jonathan-innis jonathan-innis force-pushed the joinnis/image-policy branch 2 times, most recently from f2d30ca to bd069fa Compare February 7, 2021 00:10
@stefanprodan
Copy link
Member

@jonathan-innis can you please rebase with main, the e2e tests will fail after that, you need to change ./bin/flux get image policy podinfo | grep '5.0.3' to match your policies.

@jonathan-innis
Copy link
Contributor Author

@jonathan-innis can you please rebase with main, the e2e tests will fail after that, you need to change ./bin/flux get image policy podinfo | grep '5.0.3' to match your policies.

Rebased

stefanprodan
stefanprodan approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jonathan-innis 🏅

@stefanprodan stefanprodan merged commit 35507c7 into fluxcd:main Feb 9, 2021
squaremo
squaremo reviewed Feb 9, 2021
View reviewed changes
cmd/flux/create_image_policy.go
}
template = rest
if num >= 0 {
// we won't worry about numbers as we can't validate these
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could check it against exp.MaxCap() (exp from the caller).

@stefanprodan stefanprodan mentioned this pull request Feb 10, 2021
Closed
29 tasks
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
@stefanprodan
Merge pull request fluxcd#860 from souleb/docs-using-auto-login
02ff549 
[OCI] Document Auto-Login usage in SC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squaremo squaremo squaremo approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/image-automation Automated image updates related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support alphabetical policy and filter .extract in flux create image policy
4 participants
@jonathan-innis @stefanprodan @squaremo @hiddeco