Image automation migration guide #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Feb 1, 2021
squaremo
force-pushed
the
image-auto-migration-howto
branch
3 times, most recently
from
f56b910 to
8574367
Compare
stefanprodan
reviewed
Feb 8, 2021
29 tasks
squaremo
changed the title
hiddeco
added
area/docs
stefanprodan
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
LGTM
Awesome guide @squaremo I added a suggestion on using numerical but it's no blocker.
squaremo
force-pushed
the
image-auto-migration-howto
branch
4 times, most recently
from
174d2fe to
1a5f99a
Compare
This doc describes how to move from using Flux v1 to update image refs in git, to using Flux v2. There is some overlap with the tutorial on how to use Flux v2 automation. This how-to spends more time on how to convert existing configuration to be used with Flux v2. Signed-off-by: Michael Bridgen <[email protected]>
The Flux v1 migration how-to flows better if the section on how to set builds up to tag images in the right way is its own document. It's a lot to skim past when you don't need it, and (since it's a different layer of yak hair) something you might want to figure out first if you do need it. Signed-off-by: Michael Bridgen <[email protected]>
Previously, creating an automation object was the last instruction. It is easier to describe what to expect at each step when the last step is to add an update marker in the file to be updated, since the next thing that should happen is that the automation makes an update as a consequence. This commit shifts the sections around so that setting up the GitRepository and ImageUpdateAutomation are done earlier, and migrating each file are done after that, and completes the steps described including checking the expected status at each stage. Signed-off-by: Michael Bridgen <[email protected]>
Using a commit number is trickier than it sounds. It would need to be padded to sort correctly, for one thing. It is better to leave it out than to give an incomplete account. Signed-off-by: Michael Bridgen <[email protected]>
I have moved TODO comments (that still apply) to the PR description. Signed-off-by: Michael Bridgen <[email protected]>
Signed-off-by: Michael Bridgen <[email protected]>
Signed-off-by: Michael Bridgen <[email protected]>
Stray characters here and there threw off the markdown engine. Signed-off-by: Michael Bridgen <[email protected]>
Signed-off-by: Michael Bridgen <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
image-auto-migration-howto
branch
from
9b66c5f to
3777044
Compare
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
image-auto-migration-howto
branch
from
3777044 to
51a4dae
Compare
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
image-auto-migration-howto
branch
from
51a4dae to
30c1c5c
Compare
stefanprodan
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #736
TODO:
(EDIT) Save these for another guide: