Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Go 1.23 #4936

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Build with Go 1.23 #4936

merged 2 commits into from
Aug 15, 2024

Conversation

stefanprodan
Copy link
Member

Part of: #4927

Signed-off-by: Stefan Prodan <[email protected]>
@stefanprodan stefanprodan added the area/ci CI related issues and pull requests label Aug 15, 2024
@stefanprodan stefanprodan requested a review from a team August 15, 2024 11:12
Dockerfile Outdated

RUN apk add --no-cache ca-certificates curl

ARG ARCH=linux/amd64
ARG KUBECTL_VER=1.30.0
ARG KUBECTL_VER=1.33.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ARG KUBECTL_VER=1.33.0
ARG KUBECTL_VER=1.31.0

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@makkes
Copy link
Member

makkes commented Aug 15, 2024

I suppose we should also update .github/runners/prereq.sh to use kubectl 1.31.

@stefanprodan
Copy link
Member Author

The runners have been decommissioned, we no longer use Equinix. We are now using GitHub EE ARM runners.

@stefanprodan stefanprodan merged commit cc87ffd into main Aug 15, 2024
9 of 10 checks passed
@stefanprodan stefanprodan deleted the go-1.23 branch August 15, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants