Fix wrong deletion message on flux diff #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
added
bug
souleb
force-pushed
the
fix-deleted-mess-diff
branch
2 times, most recently
from
8dc2a98 to
3e0c22b
Compare
souleb
force-pushed
the
fix-deleted-mess-diff
branch
from
3e0c22b to
f30a8ba
Compare
If implemented, when an error happens when dry-running an object, we return early. This match pkg ssa implementation Signed-off-by: Soule BA <[email protected]>
souleb
force-pushed
the
fix-deleted-mess-diff
branch
from
f30a8ba to
8b44428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If implemented, when error happens in dry-run and we have pruning
enforced, the deletion message will be consistent
Signed-off-by: Soule BA [email protected]