-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Google Chat alerts #953
Conversation
Signed-off-by: fpinna <[email protected]>
Signed-off-by: fpinna <[email protected]>
Signed-off-by: fpinna <[email protected]>
Signed-off-by: fpinna <[email protected]>
Just want to give you a heads up that @stefanprodan is out on holidays and this PR probably won't be reviewed before he is back (in two weeks). |
Thank you for your feedback. |
Signed-off-by: fpinna <[email protected]>
Was this tested? I really doubt it works since the gchat is missing from the Notifier Factory. |
Signed-off-by: fpinna <[email protected]>
Sorry, my bad. I made mistakes with my last commit. |
@@ -1191,6 +1191,7 @@ spec: | |||
- msteams | |||
- discord | |||
- rocket | |||
- gchat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this to artifacts/flagger/crd.yaml
then run make crd
and commit all changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: fpinna <[email protected]>
pkg/notifier/factory.go
Outdated
@@ -52,6 +52,8 @@ func (f Factory) Notifier(provider string) (Interface, error) { | |||
n, err = NewRocket(f.URL, f.ProxyURL, f.Username, f.Channel) | |||
case "msteams": | |||
n, err = NewMSTeams(f.URL, f.ProxyURL) | |||
case "gchat": | |||
n, err = NewMSTeams(f.URL, f.ProxyURL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be NewGChat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
thanks
Codecov Report
@@ Coverage Diff @@
## main #953 +/- ##
==========================================
+ Coverage 56.91% 56.97% +0.05%
==========================================
Files 71 73 +2
Lines 5861 5924 +63
==========================================
+ Hits 3336 3375 +39
- Misses 2030 2048 +18
- Partials 495 501 +6
Continue to review full report at Codecov.
|
Signed-off-by: fpinna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @fpinna
Add google chat alerting support