Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to mute alerts generated from webhooks #887

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

mayankshah1607
Copy link
Contributor

Alternate solution for #886

Signed-off-by: Mayank Shah [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #887 (975b84a) into main (3e845f1) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   56.68%   56.61%   -0.07%     
==========================================
  Files          67       67              
  Lines        5439     5442       +3     
==========================================
- Hits         3083     3081       -2     
- Misses       1896     1901       +5     
  Partials      460      460              
Impacted Files Coverage Δ
pkg/controller/scheduler_hooks.go 8.82% <0.00%> (-0.41%) ⬇️
pkg/canary/config_tracker.go 82.35% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e845f1...975b84a. Read the comment docs.

Signed-off-by: Mayank Shah <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mayankshah1607

@stefanprodan stefanprodan merged commit a590968 into fluxcd:main Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants