Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Flagger logo #812

Merged
merged 4 commits into from
Feb 15, 2021
Merged

New Flagger logo #812

merged 4 commits into from
Feb 15, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Feb 13, 2021

Changes:

  • Add logo pack (designed by @bia)
  • Update Helm charts
  • Update diagrams

Design by Bianca Cheng Costanzo

Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
@dholbach
Copy link
Member

dholbach commented Feb 15, 2021

I just reviewed the diagrams, here's the list that need updating:

Remove

  • docs/logo/flagger-weaveworks.svg
  • docs/logo/weaveworks.png

Update

  • docs/diagrams/flagger-abtest-steps.png
  • docs/diagrams/flagger-bluegreen-steps.png
  • docs/diagrams/flagger-canary-hpa.png
  • docs/diagrams/flagger-canary-overview.png
  • docs/diagrams/flagger-canary-traffic-mirroring.png
  • docs/diagrams/flagger-contour-overview.png
  • docs/diagrams/flagger-flux-gitops.png
  • docs/diagrams/flagger-gitops-aws.png
  • docs/diagrams/flagger-gitops-contour.png
  • docs/diagrams/flagger-gitops-istio.png
  • docs/diagrams/flagger-gke-istio.png
  • docs/diagrams/flagger-gloo-overview.png
  • docs/diagrams/flagger-linkerd-traffic-split.png
  • docs/diagrams/flagger-load-testing.png
  • docs/diagrams/flagger-nginx-linkerd.png
  • docs/diagrams/flagger-nginx-overview.png
  • docs/diagrams/flagger-overview.png
  • docs/diagrams/flagger-skipper-overview.png

Let me know if you want me to file a PR to change the following:

Docs:

diff --git docs/gitbook/tutorials/canary-helm-gitops.md docs/gitbook/tutorials/canary-helm-gitops.md
index f27355c2..2d1e57f6 100644
--- docs/gitbook/tutorials/canary-helm-gitops.md
+++ docs/gitbook/tutorials/canary-helm-gitops.md
@@ -266,7 +266,7 @@ metadata:
 spec:
   releaseName: frontend
   chart:
-    git: https://github.com/weaveowrks/flagger
+    git: https://github.com/fluxcd/flagger
     ref: master
     path: charts/podinfo
   values:

Signed-off-by: Stefan Prodan <[email protected]>
@dholbach
Copy link
Member

Nice work @stefanprodan - I noticed flagger-gke-istio.png still needs the new logo, but apart from that everything looks beautiful!

Signed-off-by: Stefan Prodan <[email protected]>
@stefanprodan
Copy link
Member Author

stefanprodan commented Feb 15, 2021

The canary-helm-gitops.md is no longer used and will be deleted. As for the GKE diagram, the Istio logo is ok as it shows Flagger manipulating Istio object.

@stefanprodan
Copy link
Member Author

As for the weaveworks SVGs, I can't delete that until we update Flagger in the Cloud Native Landscape.

@dholbach
Copy link
Member

Screenshot from 2021-02-15 13-21-13

^ this is in the GKE diagram..

@dholbach
Copy link
Member

Apart from that big 👍 !

@dholbach
Copy link
Member

Ah ok nevermind - I understood your comment now.

Copy link
Member

@dholbach dholbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @stefanprodan!

@stefanprodan stefanprodan merged commit fa14ceb into main Feb 15, 2021
@stefanprodan stefanprodan deleted the new-logo branch February 15, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants