Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing TrackedConfig field to Canary status CRD #781

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

kyanagimoto
Copy link
Contributor

@kyanagimoto kyanagimoto commented Jan 19, 2021

Fix: #780

When using secret with Canary deployment, Canary deployment repeated again and again.
This PullRequest is fixing this issue.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for finding this, I was looking at unit tests and I couldn’t figure anything wrong.

@stefanprodan stefanprodan changed the title chore: reproduce restart analysis issue Add missing TrackedConfig field to Canary status CRD Jan 19, 2021
@stefanprodan stefanprodan merged commit 45fddab into fluxcd:main Jan 19, 2021
@kyanagimoto kyanagimoto deleted the secret-restart-analysis branch January 19, 2021 12:09
@kyanagimoto kyanagimoto restored the secret-restart-analysis branch January 19, 2021 12:11
@kyanagimoto kyanagimoto deleted the secret-restart-analysis branch January 19, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: adding an env var from a secretKeyRef causes Canary to never progress
3 participants