Refactor canary change detection and status #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the pod template spec hash to track changes (breaking)
Add Promoted status condition with the following reasons: Initialized, Progressing, Succeeded, Failed Usage: `kubectl wait canary/app --for=condition=promoted` Fix: #184
Fix HPA reconciliation min replicas diff
Save the primary spec hash and check if it matches the canary spec. If the canary hash is identical with the primary one skip promotion.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl wait canary/app --for=condition=promotedFix: Support status conditions #184Breaking changes: due to the status sub-resource changes, when upgrading Flagger the canaries status phase will be reset to
Initialized