add support for deploymentLabels #1707
Open
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: quintonm <[email protected]>
aryan9600
reviewed
Oct 6, 2024
|
Could this be used to address the issues raised in #1312? |
|
@KrylixZA i'm investigating that. i'd say if that needs to be addressed, we shall do so in a different PR, since they're completely different things. |
Signed-off-by: quintonm <[email protected]>
|
@aryan9600 README has been updated. Should I make a similar update to docs/gitbook/install/flagger-install-on-kubernetes.md? |
|
Sure, that'd be great. Could you also specify the |
charts/flagger/values.yaml
Outdated
Comment on lines
202
to
203
| deploymentLabels: | ||
| mylabel: value |
There was a problem hiding this comment.
Suggested change
| deploymentLabels: | |
| mylabel: value | |
| deploymentLabels: {} |
Signed-off-by: quintonm <[email protected]>
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring additional labels for the deployment using
deploymentLabelsinvalues.yaml.