feat: Webhook retries #1541
Merged
feat: Webhook retries #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
reviewed
Nov 1, 2023
Kwasniewski
force-pushed
the
webhook_retries
branch
from
d717e87
to
4a36533
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
+ Coverage 55.03% 55.04% +0.01%
==========================================
Files 85 85
Lines 10355 10358 +3
==========================================
+ Hits 5699 5702 +3
Misses 3994 3994
Partials 662 662 ☔ View full report in Codecov by Sentry. |
stefanprodan
added
the
kind/enhancement
stefanprodan
approved these changes
Nov 8, 2023
aryan9600
reviewed
Nov 14, 2023
aryan9600
reviewed
Nov 17, 2023
|
hey @Kwasniewski, we were hoping to get this out in the next release which is planned for next week, so it'd be great if you could finish the few remaining bits and get this over the line! no pressure tho :) |
Add a new field `.spec.webhooks[].retries` to specify the number of retries when calling a webhook. Signed-off-by: Joseph Kwasniewski <[email protected]>
aryan9600
force-pushed
the
webhook_retries
branch
from
d5f4bb5
to
ad8e7d6
Compare
|
Sorry about looking at this slowly, I was away for a bit. The changes look great you put in place! Let me know if there are any other changes you want in place. |
stefanprodan
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in configurable retries to all webhooks.
This is helpful in our use-case where webhooks can fail several times, but would prefer not to increment the canary iteration failure count.