-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Copy slowStartConfig for Gloo upstreams #1455
Conversation
631e965
to
66d5a94
Compare
Can you also update the Gloo version in e2e tests to latest stable please? It's here https://github.com/fluxcd/flagger/blob/main/test/gloo/install.sh#L5 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1455 +/- ##
==========================================
+ Coverage 54.42% 54.52% +0.09%
==========================================
Files 84 84
Lines 10049 10143 +94
==========================================
+ Hits 5469 5530 +61
- Misses 3925 3956 +31
- Partials 655 657 +2
☔ View full report in Codecov by Sentry. |
@stefanprodan Regarding failed test run: I created the I'm going to update the double/duration types to the Go primitives instead for the |
@nickcaballero could you please squash and rebase on main? should be good to merge after that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @nickcaballero 🎖️
Signed-off-by: Nick Caballero <[email protected]>
11f8927
to
8747d15
Compare
Now that Gloo supports Envoy's slow start mode (solo-io/gloo#7810), this PR ensures that
slowStartConfig
is copied to the generated upstreams.