Run confirm-rollout checks only before scaling up deployment
#1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
+ Coverage 54.62% 54.67% +0.04%
==========================================
Files 84 84
Lines 10114 10114
==========================================
+ Hits 5525 5530 +5
+ Misses 3936 3929 -7
- Partials 653 655 +2
☔ View full report in Codecov by Sentry. |
Run the `confirm-rollout` webhook check right before scaling up the deployment only, instead of running it on every loop. Signed-off-by: Sanskar Jaiswal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
confirm-rolloutwebhook is called on every canary run, regardless of its phase. This PR changes the scheduler to run it only when a canary run is triggered and right before the canary deployment is scaled up. Furthermore, the webhook is now called with the current phase of the canary instead ofProgressingregardless of the actual phase.