Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Flux helm drift detection for managed resources #1408

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

aryan9600
Copy link
Member

Disable helm-controller drift detection for managed resources by adding the helm.toolkit.fluxcd.io/driftDetection: disabled annotation to the resource. (ref: https://fluxcd.io/flux/components/helm/helmreleases/#excluding-resources-from-drift-detection)

Fixes #1407

@stefanprodan stefanprodan changed the title disable flux helm drift detection for managed resources Disable Flux helm drift detection for managed resources Apr 10, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🏅

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f1def19) 54.47% compared to head (8229852) 54.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1408   +/-   ##
=======================================
  Coverage   54.47%   54.47%           
=======================================
  Files          84       84           
  Lines       10047    10048    +1     
=======================================
+ Hits         5473     5474    +1     
  Misses       3921     3921           
  Partials      653      653           
Impacted Files Coverage Δ
pkg/router/util.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aryan9600 aryan9600 merged commit 5b7a679 into main Apr 10, 2023
@aryan9600 aryan9600 deleted the helm-drift branch April 10, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm-controller drift-detection collides with flagger's default selectorLabels
3 participants