-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow access to Prometheus in OpenShift via SA token #1338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for opening this PR!
Codecov ReportBase: 54.24% // Head: 54.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
==========================================
+ Coverage 54.24% 54.27% +0.02%
==========================================
Files 84 84
Lines 10016 10022 +6
==========================================
+ Hits 5433 5439 +6
Misses 3927 3927
Partials 656 656
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@wwadge Could you please squash all commits into one? |
f280f27
to
1b17b5d
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one small nitpick, and we should be good to go :)
Fixes: fluxcd#1064 Signed-off-by: Wallace Wadge <[email protected]>
62fa012
to
a50d7de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
thanks @wwadge 🙇
Fixes: #1064
We can already access prometheus using Basic Auth. This PR adds support to access prometheus using Authorization: Bearer token too.
Signed-off-by: Wallace Wadge [email protected]