Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loadtester: logCmdOutput to logger instead of stdout #1267

Merged
merged 1 commit into from
Sep 27, 2022
Merged

loadtester: logCmdOutput to logger instead of stdout #1267

merged 1 commit into from
Sep 27, 2022

Conversation

oistein
Copy link
Contributor

@oistein oistein commented Sep 16, 2022

To be able to keep log context use logger instead of stdout.

Signed-off-by: Øistein Sletten Løvik [email protected]

aryan9600
aryan9600 requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @oistein, thanks for this PR, it just needs a minor change

pkg/loadtester/bash.go Outdated Show resolved Hide resolved
pkg/loadtester/helmv3.go Outdated Show resolved Hide resolved
pkg/loadtester/task_shell.go Outdated Show resolved Hide resolved
@oistein
logCmdOutput to logger instead of stdout
6d72050 
Signed-off-by: Øistein Sletten Løvik <[email protected]>
@oistein
Copy link
Contributor Author

oistein commented Sep 26, 2022

Thanks @aryan9600 , updated and rebased

aryan9600
aryan9600 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @oistein 🙇

@aryan9600 aryan9600 merged commit 1b2df99 into fluxcd:main Sep 27, 2022
@oistein oistein deleted the log-cmd-output-to-log branch September 27, 2022 09:20
@stefanprodan stefanprodan changed the title logCmdOutput to logger instead of stdout loadtester: logCmdOutput to logger instead of stdout Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryan9600 aryan9600 aryan9600 approved these changes

@stefanprodan stefanprodan Awaiting requested review from stefanprodan stefanprodan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oistein @aryan9600