update guide for flagger on aliyun ASM #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokoyang
force-pushed
the
doc-update-for-flagger-install-on-asm
branch
from
6cb1c98
to
0827c6e
Compare
Sorry I forgot, I've signoff it now. |
aryan9600
requested changes
Jun 22, 2022
|
I removed extra blank line. |
yokoyang
force-pushed
the
doc-update-for-flagger-install-on-asm
branch
from
c1c7c9a
to
1f92269
Compare
thanks, I have squash my commits now. |
Signed-off-by: 奇方 <[email protected]>
yokoyang
force-pushed
the
doc-update-for-flagger-install-on-asm
branch
from
1f92269
to
4f64377
Compare
|
OSM e2e tests are failing, but merging anyway as the changes in this PR are completely unrelated. The failing e2e test needs to be investigated separately. |
dholbach
reviewed
Jul 13, 2022
| ```yaml | ||
| kubectl apply -f $FLAGGER_SRC/artifacts/flagger/crd.yaml | ||
| ```bash | ||
| kubectl apply -f https://raw.githubusercontent.com/fluxcd/flagger/v1.21.0/artifacts/flagger/crd.yaml |
There was a problem hiding this comment.
The latest release of Flagger is now v1.22.0. Maybe it'd be good to have some kind of
VERSION=$(curl -s "https://api.github.com/repos/fluxcd/flagger/releases" | jq -r '.[] | .tag_name' | sort -V | tail -n 1)
logic here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a developer on the Alibaba Service Mesh ASM team. The previous documentation flagger-install-on-alibaba-servicemesh is outdated, I have made some updates to the content.