-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for KEDA ScaledObjects as an auto scaler #1216
Conversation
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
+ Coverage 54.72% 54.73% +0.01%
==========================================
Files 80 81 +1
Lines 6822 6948 +126
==========================================
+ Hits 3733 3803 +70
- Misses 2510 2550 +40
- Partials 579 595 +16
Continue to review full report at Codecov.
|
ea4d74f
to
475bab0
Compare
Signed-off-by: Sanskar Jaiswal <[email protected]>
475bab0
to
b01e4cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, please add tests for primaryScalerQueries
.
a2a7054
to
a1b0231
Compare
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
a1b0231
to
377a8f4
Compare
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @aryan9600 🥇
This PR adds support for KEDA
ScaledObjects
to be used as an auto scaler for workloads. A newScalerReconciler
namedScaledObjectReconciler
has been introduced which reconcilesScaledObjects
. Users can specify a reference to their existingScaledObject
using.spec.autoscalerRef
in theCanary
definition.Fixes: #1118