Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for helmv2 in loadtester #1130

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented Mar 8, 2022

Remove support for Helm 2 from the loadtester. The webhook types "helm" and "helmv3" are now aliases, both invoke Helm 3.

Fix: #1129

Signed-off-by: Sanskar Jaiswal [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #1130 (1b43f19) into main (090329d) will increase coverage by 0.29%.
The diff coverage is 0.00%.

❗ Current head 1b43f19 differs from pull request most recent head 5acf189. Consider uploading reports for the commit 5acf189 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   56.99%   57.29%   +0.29%     
==========================================
  Files          79       78       -1     
  Lines        6376     6343      -33     
==========================================
  Hits         3634     3634              
+ Misses       2199     2166      -33     
  Partials      543      543              
Impacted Files Coverage Δ
pkg/loadtester/helmv3.go 0.00% <ø> (ø)
pkg/loadtester/server.go 12.50% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090329d...5acf189. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadtester: Remove Helm v2 binaries
3 participants