Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] primaryReadyThreshold: allow configuring threshold for primary #1048

Merged
merged 1 commit into from
Nov 17, 2021
Merged

[feat] primaryReadyThreshold: allow configuring threshold for primary #1048

merged 1 commit into from
Nov 17, 2021

Conversation

mdibaiee
Copy link
Contributor

see #639

@mdibaiee mdibaiee force-pushed the primary-ready-threshold branch 5 times, most recently from 9c06fd4 to 0d38a4b Compare November 10, 2021 15:09
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #1048 (0d38a4b) into main (9c7db58) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0d38a4b differs from pull request most recent head 8f50521. Consider uploading reports for the commit 8f50521 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   57.15%   57.15%           
=======================================
  Files          76       76           
  Lines        6138     6139    +1     
=======================================
+ Hits         3508     3509    +1     
  Misses       2103     2103           
  Partials      527      527
Impacted Files Coverage Δ
pkg/canary/deployment_ready.go 76.92% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7db58...8f50521. Read the comment docs.

@stefanprodan stefanprodan added the kind/feature Feature request label Nov 11, 2021
@mdibaiee
Copy link
Contributor Author

@stefanprodan should I also write this for DaemonSet?

@mdibaiee mdibaiee marked this pull request as ready for review November 11, 2021 13:56
@stefanprodan
Copy link
Member

should I also write this for DaemonSet?

yes please

@mdibaiee mdibaiee force-pushed the primary-ready-threshold branch 6 times, most recently from aae14c8 to 5cc36a0 Compare November 11, 2021 14:44
@mdibaiee
Copy link
Contributor Author

@stefanprodan this is ready for review 👍

stefanprodan
stefanprodan approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mdibaiee 🥇

@mdibaiee
Copy link
Contributor Author

Thank you @stefanprodan for the prompt replies and review!
Any idea when the next version might be released including this change?

@stefanprodan
Copy link
Member

Any idea when the next version might be released including this change?

By the end of the next week

@stefanprodan stefanprodan merged commit 2ddd958 into fluxcd:main Nov 17, 2021
@mdibaiee mdibaiee deleted the primary-ready-threshold branch November 22, 2021 10:55
@mdibaiee
Copy link
Contributor Author

@stefanprodan thank you for merging! Can this be released as a new tag for us to use it from upstream, or are we waiting for some process / schedule to release a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
kind/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdibaiee @codecov-commenter @stefanprodan