Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support Graphite metrics provider #911

Closed
mdb opened this issue May 17, 2021 · 2 comments · Fixed by #915
Closed

Feature request: Support Graphite metrics provider #911

mdb opened this issue May 17, 2021 · 2 comments · Fixed by #915

Comments

@mdb
Copy link
Contributor

mdb commented May 17, 2021

Describe the feature

Thanks for your work on Flagger! At HBO Max, we're interested in experimenting with Flagger in support of progressive deployments, though many of our microservices' metrics currently live in Graphite.

Proposed solution

It would be great if Flagger supported a Graphite metrics provider (And we have some work in progress to add this support at https://github.com/HBOCodeLabs/flagger; stay posted for a PR soon 😃 )

Any alternatives you've considered?

We have considered making use of an already-supported metrics provider -- and eventually hope to make more use of Prometheus -- though the effort required for us to do so in the near term outweighs the effort required to add Graphite support to Flagger. Furthermore, others may benefit from Flagger Graphite support. 😃

@hiddeco
Copy link
Member

hiddeco commented May 18, 2021

Just a friendly heads-up that this issue isn't being ignored, but that @stefanprodan is enjoying well-deserved time off this week. He will probably get back to you next week. 🌻

@mdb
Copy link
Contributor Author

mdb commented May 18, 2021

Thanks for the update @hiddeco ! Hopefully we'll have an implementation PR'd by then =)

mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 21, 2021
This adds a Graphite metric provider to address
issue fluxcd#911.

Co-authored-by: Mike Ball <[email protected]>
Co-authored-by: Nathan Mische <[email protected]>
Signed-off-by: Mike Ball <[email protected]>
mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 24, 2021
This adds a Graphite metric provider to address
issue fluxcd#911.

Co-authored-by: Mike Ball <[email protected]>
Co-authored-by: Nathan Mische <[email protected]>
Signed-off-by: Mike Ball <[email protected]>
Signed-off-by: Nathan Mische <[email protected]>
mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 24, 2021
This adds documentation of the Graphite metrics
provider in support of addressing issue fluxcd#911.

Co-authored-by: Mike Ball [email protected]
Co-authored-by: Nathan Mische [email protected]
Signed-off-by: Mike Ball [email protected]
Signed-off-by: Nathan Mische [email protected]
mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 24, 2021
This adds documentation of the Graphite metrics
provider in support of addressing issue fluxcd#911.

Co-authored-by: Mike Ball [email protected]
Co-authored-by: Nathan Mische [email protected]
Signed-off-by: Mike Ball [email protected]
Signed-off-by: Nathan Mische [email protected]
mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 24, 2021
This adds documentation of the Graphite metrics
provider in support of addressing issue fluxcd#911.

Co-authored-by: Mike Ball [email protected]
Co-authored-by: Nathan Mische [email protected]
Signed-off-by: Mike Ball [email protected]
Signed-off-by: Nathan Mische [email protected]
mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 24, 2021
This adds documentation of the Graphite metrics
provider in support of addressing issue fluxcd#911.

Co-authored-by: Mike Ball [email protected]
Co-authored-by: Nathan Mische [email protected]
Signed-off-by: Mike Ball [email protected]
Signed-off-by: Nathan Mische [email protected]
mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 24, 2021
This adds documentation of the Graphite metrics
provider in support of addressing issue fluxcd#911.

Co-authored-by: Mike Ball [email protected]
Co-authored-by: Nathan Mische [email protected]
Signed-off-by: Mike Ball [email protected]
Signed-off-by: Nathan Mische [email protected]
mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 24, 2021
This adds documentation of the Graphite metrics
provider in support of addressing issue fluxcd#911.

Co-authored-by: Mike Ball [email protected]
Co-authored-by: Nathan Mische [email protected]
Signed-off-by: Mike Ball [email protected]
Signed-off-by: Nathan Mische [email protected]
mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 24, 2021
This adds documentation of the Graphite metrics
provider in support of addressing issue fluxcd#911.

Co-authored-by: Mike Ball [email protected]
Co-authored-by: Nathan Mische [email protected]
Signed-off-by: Mike Ball [email protected]
Signed-off-by: Nathan Mische [email protected]
mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 24, 2021
This adds documentation of the Graphite metrics
provider in support of addressing issue fluxcd#911.

Co-authored-by: Mike Ball [email protected]
Co-authored-by: Nathan Mische [email protected]
Signed-off-by: Mike Ball [email protected]
Signed-off-by: Nathan Mische [email protected]
mdb added a commit to HBOCodeLabs/flagger that referenced this issue May 24, 2021
This adds documentation of the Graphite metrics
provider in support of addressing issue fluxcd#911.

Co-authored-by: Mike Ball <[email protected]>
Co-authored-by: Nathan Mische <[email protected]>
Signed-off-by: Mike Ball <[email protected]>
Signed-off-by: Nathan Mische <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants