Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general CONTRIBUTING information #5

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Add general CONTRIBUTING information #5

merged 1 commit into from
Oct 26, 2021

Conversation

dholbach
Copy link
Member

Largely copied from f/flux2.

Addresses #4.

Signed-off-by: Daniel Holbach [email protected]

	Largely copied from f/flux2.

	Addresses #4.

Signed-off-by: Daniel Holbach <[email protected]>
@dholbach dholbach linked an issue Oct 25, 2021 that may be closed by this pull request
@dholbach
Copy link
Member Author

The idea would be to remove duplicate information across all repos and move information like "how to build source-controller" to e.g. f/source-controller/DEVELOPMENT.md.

We should import this file into fluxcd.io/contributing and link to this file from all project-specific DEVELOPMENT.md files (like e.g. source-controller) mentioned above.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @dholbach

@dholbach dholbach merged commit 56dd444 into fluxcd:main Oct 26, 2021
@dholbach dholbach deleted the add-contributing branch October 26, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider centralising general CONTRIBUTOR documentation
2 participants