Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): added basic flux2-multi-tenancy chart #51

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

haarchri
Copy link
Collaborator

Signed-off-by: haarchri [email protected]

What this PR does / why we need it:

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested

@haarchri haarchri requested a review from dwerder December 13, 2021 15:43
Signed-off-by: Daniel Werdermann <[email protected]>
@dwerder dwerder self-requested a review December 14, 2021 16:04
@dwerder dwerder merged commit b82f287 into fluxcd-community:main Dec 14, 2021
@stefanprodan
Copy link
Member

Hmm this name is super confusing, what will happen to this chart when we'll implement: fluxcd/flux2#2093 ?

@stefanprodan
Copy link
Member

Flux multi-tenancy can be implemented to with many other solutions e.g. OPA Gatekeep, at least please rename this to something that has Kyverno in the name.

@dwerder
Copy link
Collaborator

dwerder commented Dec 14, 2021

It was named so, because it is the implementation of https://github.com/fluxcd/flux2-multi-tenancy
So the name seem to be legit.

@dwerder
Copy link
Collaborator

dwerder commented Dec 14, 2021

Should we rename it to flux2-multi-tenancy-kyverno ?

@dwerder
Copy link
Collaborator

dwerder commented Dec 14, 2021

Alternativly we can stick to it and use it in the future for other implementation as well. Loke OPA
Then users can choose, And it is already implemted by kyverno.enabled | bool | false

@stefanprodan
Copy link
Member

stefanprodan commented Dec 14, 2021

Are we going to delete this chart once RFC-0003 gets in? The flux2-multi-tenancy repo will use the new bootstrap option.

@dwerder
Copy link
Collaborator

dwerder commented Dec 14, 2021

Then we can adjust it (and have a major version bump) or delete it, If it gets totally obsolet.

@stefanprodan
Copy link
Member

Cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants