-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional helpful spans to opaque struct field access diagnostics #862
Conversation
Closes (#835). |
@nilehmann, is there a straight forward way to get the span for the wrapping function? I only know how to get the struct's (and it's related impls) span, since it seems like the span for the field access in the function body has no parent. |
no, there's no easy way right now. When we construct a |
d50fe31
to
361db23
Compare
666e636
to
67ee369
Compare
Hmm, not sure why the CI stuff is failing. It builds fine locally, and the line it's complaining about is different than what the dialog points to... |
@vrindisbacher I think you local branch is too old. The ci is failing because it runs on the code after being merged with main. |
67ee369
to
0e1ec54
Compare
See here