rfc14: add bank and project as optional jobspec attributes #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
approved these changes
Aug 6, 2024
spec_14.rst
Outdated
|
|
||
| **project** | ||
| The value of the ``project`` attribute is a string containing the name | ||
| of an accounting project requested for this job. Actually support for |
There was a problem hiding this comment.
IMHO I'd drop the word completely, e.g. just say "Support for the project attribute..."
There was a problem hiding this comment.
Removed that from both stanzas and will set MWP.
This was referenced Aug 6, 2024
Problem: The canonical jobspec attributes for `bank` and `project` are not specified in RFC 14. Even though these attributes only apply for multi-user instances with an accounting plugin configured, they are common enough concepts that it would be useful to standardize their name, location in jobspec, and purpose. Define `bank` and `project` attributes in RFC 14. Add a note that these attributes may have no effect unless an accounting package is installed and configured.
Problem: Access to https://blog.twitter.com gets 403 Forbidden with `make linkcheck` in CI. Add this URL to the ignore list for linkcheck.
grondo
force-pushed
the
rfc14-bank-and-project
branch
from
6585b5a to
55ad563
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The canonical jobspec attributes for
bankandprojectare not specified in RFC 14. Even though these attributes only apply for multi-user instances with an accounting plugin configured, they are common enough concepts that it would be useful to standardize their name, location in jobspec, and purpose.Define
bankandprojectattributes in RFC 14. Add a note that these attributes may have no effect unless an accounting package is installed and configured.