Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] rfc21: document job reattach events #303

Closed
wants to merge 1 commit into from

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Nov 12, 2021

This documents what I did in flux-framework/flux-core#3947

I don't know if this should really be considered a mergeable candidate, but mostly wanted to just document what is in that PR and/or potentially lead to discussion. The terminology "reattach" is of course debatable.

@garlick
Copy link
Member

garlick commented Nov 12, 2021

What do the events signify, and do they need to be in the main eventlog or should the shells log disconnect/reconnect events in their eventlog?

@chu11
Copy link
Member Author

chu11 commented Nov 13, 2021

What do the events signify, and do they need to be in the main eventlog or should the shells log disconnect/reconnect events in their eventlog?

At the moment they are informational. So perhaps they don't even need to be documented? Or don't even need to be in the eventlog? The only reason I put them in the eventlog is that we want to know when a job has been "reattached", because there's info that could be lost.

For example, we normally calculate runtime by calculating t_cleanup - t_run timestamps. But in a "reattach" case, this runtime calculation may not be accurate b/c a job may have finished before we reattached and output the cleanup state to the eventlog. (Edit: I have no idea how to solve in the simulated case. In the systemd case longer out will probably have extra information and can do something to estimate a more accurate runtime)

@chu11
Copy link
Member Author

chu11 commented Nov 17, 2021

closing, for the purposes of flux-framework/flux-core#3947 decided to prefix eventlog events with debug as we design the longer term solution

@chu11 chu11 closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants