Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc25: add moldable specification into Jobspec V1 #302

Closed
wants to merge 1 commit into from

Conversation

dongahn
Copy link
Member

@dongahn dongahn commented Oct 30, 2021

Copy the moldable specification from our canonical
job spec (RFC14) to job spec version 1 (RFC25).

Need to support a moldable jobspec including
resources.count.min both within flux-core and
fluxion in order to enable node-exclusive scheduling
(e.g., typical system instance scheduling policy).

@dongahn dongahn requested a review from grondo October 30, 2021 05:42
@dongahn
Copy link
Member Author

dongahn commented Oct 30, 2021

This should not be merged until Issue flux-framework/flux-core#3928 is resolved.

@grondo
Copy link
Contributor

grondo commented Nov 10, 2021

I wonder if we should make things easier on ourselves (at least for flux-core) only allow count or a min keyword for V1 jobspec, instead of also allowing the optional max, operator and operand keys?

I don't feel too strongly about this, but allowing those keys will be slightly more work in flux-core I assume, when we really only require the min keyword to support first-cut modlable jobs.

@dongahn
Copy link
Member Author

dongahn commented Nov 10, 2021

I don't feel too strongly about this, but allowing those keys will be slightly more work in flux-core I assume, when we really only require the min keyword to support first-cut modlable jobs.

Yes, I support this idea since this will be minimum viable and I will revise the PR. @grondo: we still don't want to change the version number for our Jobspec (V1) for this minor change, correct?

Copy the minimum viable moldable specification
from our canonical job spec (RFC14) to job spec
version 1 (RFC25).

Need to support a moldable jobspec including
resources.count.min both within flux-core and
fluxion in order to enable node-exclusive scheduling
(e.g., typical system instance scheduling policy).
@dongahn
Copy link
Member Author

dongahn commented Nov 10, 2021

OK. I made the suggested change and forced a push.

@dongahn
Copy link
Member Author

dongahn commented Dec 2, 2021

Closing this PR per our discussion at today's meeting.

@dongahn dongahn closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants