Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc7: add std for variable names and typedefs #22

Merged
merged 3 commits into from
May 28, 2015

Conversation

garlick
Copy link
Member

@garlick garlick commented May 27, 2015

There was some discussion in PR flux-framework/flux-core#205 about names for function pointer typedefs.

I'm proposing that we add SHOULD-level guidelines for

  • lower case C variable names
  • upper case C preprocessor macros
  • non-function typedefs: lower case ending in _t
  • function typedefs: lower case ending in _f and defined as function pointers
  • use typedef pointer to incomplete type to publicly define abstract data types

@garlick
Copy link
Member Author

garlick commented May 28, 2015

Oh, interesting. I don't especially have an opinion, so I'll force an update of this PR without the break long lines patch, and my patch conforming to the style of the original doc.

lipari pushed a commit that referenced this pull request May 28, 2015
rfc7: add std for variable names and typedefs
@lipari lipari merged commit 1dc8843 into flux-framework:master May 28, 2015
@garlick garlick deleted the spec_7_funptr branch February 7, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants