build: ensure autogen.sh updates package version #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: PACKAGE_VERSION is not updated to match "git describe" in a development tree when autogen.sh is run. The previous value is retained in the autom4te.cache directory, even when configure is regenerated, which seems counterintuitive. Add the --force option to autoreconf (as called from autogen.sh) to ensure that nothing is cached from previous builds.
grondo
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: PACKAGE_VERSION is not updated to match "git describe" in a development tree when
autogen.shis run.The previous value is retained in the
autom4te.cachedirectory, even when configure is regenerated, which seems counterintuitive.Add the
-forceoption to autoreconf (as called fromautogen.sh) to ensure that nothing is cached from previous builds.Note: this was done in flux-core back in 2022. While testing various development branches here, I managed to confuse myself by running
make deband using a distribution tarball that did not correspond to the checked out branch (doh!)