port to musl and add alpine CI build #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Some source files in src/imp include wait.h directly when the more portable solution is to include sys/wait.h. Update the locations in which wait.h is included to instead include sys/wait.h.
Problem: Some systems may not have the definitions of TMPFS_MAGIC and CGROUP_SUPER_MAGIC available (for example musl libc). Add definitions for these two values as found in linux/magic.h in RHEL 8.
Problem: A couple sources are missing a required stdint.h include.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 85.92% 85.88% -0.05%
==========================================
Files 36 36
Lines 4918 4918
==========================================
- Hits 4226 4224 -2
- Misses 692 694 +2
|
garlick
reviewed
Nov 17, 2023
| @@ -79,7 +79,7 @@ static time_t strtotime (const char *s) | |||
| { | |||
There was a problem hiding this comment.
Commit message typo here. Says %T-%m-%d(twice) but should be %Y-%m-%d.
Edit: Title also.
There was a problem hiding this comment.
Thanks. Got it and force-pushed. Will set MWP.
Problem: The %F format specifier used in strptime(3) and strftime(3) is a non-POSIX alias for %Y-%m-%d, so it fails in systems based on musl libc. Replace the %F alias with the full format %T-%m-%d.
Problem: The glob(3) implementation on musl libc does not return GLOB_ABORTED when the parent directory of the pattern does not exist, but a unit test for cf_update_glob() depends on this behavior. Skip the test if glob(3) doesn't behave as expected in this situation.
Problem: musl libc doesn't have fgetpwent_r(3), so compilation of t/src/getpwuid.c fails. The program is not multithreaded, so switch to fgetpwent(3) and getpwuid(3).
Problem: flux-security is not tested on the musl libc based alpine distribution. Add an alpine build to generate-matrix.py.
Problem: The build.os parameter is now required for readthedocs. Add a build section to readthedocs.yml.
grondo
force-pushed
the
musl-portability
branch
from
44adb43 to
30b82cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some musl libc portability issues in flux-security and adds an alpine Linux CI build so we don't break it again.