build: address warnings from autogen.sh #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: autoreconf complains about AC_CANONICAL_SYSTEM: warning: The macro `AC_CANONICAL_SYSTEM' is obsolete Use AC_CANONICAL_TARGET instead.
Problem: autoreconf complains about AM_CONFIG_HEADER warning: 'AM_CONFIG_HEADER': this macro is obsolete Use AC_CONFIG_HEADERS instead.
Problem: autoreconf complains about AC_PROG_CC_C99 warning: The macro `AC_PROG_CC_C99' is obsolete Borrow logic from flux-core to conditionally use AC_PROG_CC.
Problem: autoreconf complains about AC_HEADER_STDC: warning: The macro `AC_HEADER_STDC' is obsolete Drop it.
Problem: autoreconf complains of duplicate EXTRA_DIST src/libtomlc99/Makefile.am:54: warning: EXTRA_DIST multiply defined in condition TRUE ... src/libtomlc99/Makefile.am:12: ... 'EXTRA_DIST' previously defined here Change second EXTRA_DIST definition to an append.
Problem: autoreconf complains of configure.ac:152: warning: The macro `AC_HELP_STRING' is obsolete. configure.ac:152: You should run autoupdate. ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from... config/ac_pkgconfig.m4:3: AC_PKGCONFIG is expanded from... configure.ac:152: the top level Copy over the macro from flux-core.
Problem: autoreconf complains of configure.ac:77: warning: The macro `AC_FD_CC' is obsolete. configure.ac:77: You should run autoupdate. ./lib/autoconf/general.m4:399: AC_FD_CC is expanded from... lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:699: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... config/am_check_pymod.m4:3: AM_CHECK_PYMOD is expanded from... lib/m4sugar/m4sh.m4:699: AS_IF is expanded from... configure.ac:77: the top level Copy am_check_pymod.m4 from flux-core.
Problem: configure.ac includes an XXX comment that no longer applies. I can't tell if this is just a flag that the version comes from git now, or if it's a note to do it that way, which is already done. Either way, comment be gone!
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
- Coverage 85.92% 85.88% -0.05%
==========================================
Files 36 36
Lines 4918 4918
==========================================
- Hits 4226 4224 -2
- Misses 692 694 +2 |
|
Thanks! I'll set MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some fixes autoreconf warnings noted in #178. Much of this is just pulling over what others have already done in flux-core.
Fixes #178