build: enable PAM in make deb
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The PAM development package is missing from the list of requirements in the README. Add the missing requirement. Add a new column to the table to note that PAM is only required for --enable-pam support.
Problem: The IMP silently ignores `exec.pam-support = true` in the config file when flux-security was not built with --enable-pam. This can lead to confusion or worse if an admin erroneously thinks PAM support is working when it is not. Generate a fatal error if `exec.pam-support` is enabled when the IMP is not built with --enable-pam.
Problem: The debian package generated by `make deb` does not include support for PAM. Add the --enable-pam option to configure and add libpam0g-dev as a requesite package so that the packaged flux-security has support for PAM.
Problem: No test in the testsuite ensures that the IMP fails with an expected error if pam-support=true is specified in the config, but flux-security was built without PAM support. Add a test to t2000-imp-exec.t to ensure this error occurs.
|
readthedocs builds are failing again with I'm not exactly sure how we work around this, seems to be a readthedocs issue. Maybe we can pin urllib<2 in doc/requirements.txt? Or maybe it will fix itself later today. |
Problem: ReadTheDocs CI build currently fails with: ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2n 7 Dec 2017 See: urllib3/urllib3#2168 Workaround the issue until the builders update their OpenSSL by pinning urllib<2.
|
For now I've pinned urllib3<2 to get past the build failures. |
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=======================================
Coverage 87.08% 87.08%
=======================================
Files 33 33
Lines 4079 4082 +3
=======================================
+ Hits 3552 3555 +3
Misses 527 527
|
garlick
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debian package created by
make debwas accidentally missing--enable-pamso had no PAM support.Furthermore, the IMP silently ignores the
pam-support = trueoption in the config when built without PAM.Add PAM development packages to the suggested requirements for this project and in the
debian/controlfile, and add--enable-pamto the debian package build by default. Add an error ifpam-support=trueis specified but the IMP was not built with PAM enabled, and add a test for this error.