testsuite: start/stop all queues with --all option #992
Conversation
chu11
force-pushed
the
flux_core_pr4776
branch
from
5d667e4 to
a65ff6d
Compare
|
I think I'm contradicting myself from a couple of days ago, but should we just allow It would be nice not to break an external interface, at least not without a transition period. What do you think? |
|
ok, lets move to try and make |
|
re-opening, although we're supporting backwards compatibility, we would prefer that tests do not output an unnecessary warning message. So we'd still like to do this change. It is just no longer "breaking" if we don't do it. We can merge at our leisure after flux-framework/flux-core#4776 is merged. |
Problem: flux-core PR 4776 added the ability for queues to be individually started and stopped. As an update, starting/stopping all queues with the `flux queue` command now requires the --all option to be specified, otherwise a warning is output. To avoid the warning, update all callers to specify --all when multiple queues are started or stopped.
chu11
force-pushed
the
flux_core_pr4776
branch
from
a65ff6d to
d29c093
Compare
Codecov Report
@@ Coverage Diff @@
## master #992 +/- ##
======================================
Coverage 74.1% 74.1%
======================================
Files 78 78
Lines 9325 9325
======================================
Hits 6910 6910
Misses 2415 2415 |
chu11
added
the
merge-when-passing
Problem: if scheduler cannot reallocate resources to a running job, the scheduler interface is torn down, requiring sys admin intervention. This was seen in conjunction with flux-framework/flux-sched#992. It's not really necessary for this to be fatal to the instance. Raise a fatal exception on the job and let it be cleaned up in the usual way.
Problem: if scheduler cannot reallocate resources to a running job, the scheduler interface is torn down, requiring sys admin intervention. This was seen in conjunction with flux-framework/flux-sched#992. It's not really necessary for this to be fatal to the instance. Raise a fatal exception on the job and let it be cleaned up in the usual way.
Problem: flux-core PR 4776 added the ability for queues to be individually started and stopped. As an update, starting/stopping all queues with the
flux queuecommand now requires the --all option to be specified. This is not specified in several flux-sched tests, leading to test failures.Update all callers to specify --all when multiple queues are started or stopped.
This should not be merged until flux-framework/flux-core#4776 is merged