Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globally rename whitelist to allowlist #690

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Jul 9, 2020

This was done via simple search & replace, nothing more than that.

Fixes #669

@chu11
Copy link
Member Author

chu11 commented Jul 9, 2020

strange, all the travis tests passed, but somehow the CI wasn't notified they completed. restarted them all to see if that kicks it this time.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2020

Codecov Report

Merging #690 into master will not change coverage.
The diff coverage is 82.85%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files          78       78           
  Lines        8281     8281           
=======================================
  Hits         6210     6210           
  Misses       2071     2071           
Impacted Files Coverage Δ
resource/readers/resource_reader_base.hpp 100.00% <ø> (ø)
resource/readers/resource_reader_grug.cpp 86.82% <0.00%> (ø)
resource/readers/resource_reader_grug.hpp 100.00% <ø> (ø)
resource/readers/resource_reader_hwloc.hpp 100.00% <ø> (ø)
resource/readers/resource_reader_jgf.cpp 65.17% <0.00%> (ø)
resource/readers/resource_reader_jgf.hpp 100.00% <ø> (ø)
resource/utilities/command.hpp 100.00% <ø> (ø)
resource/modules/resource_match.cpp 76.48% <75.00%> (ø)
resource/utilities/resource-query.cpp 48.53% <77.77%> (ø)
resource/readers/resource_reader_base.cpp 80.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b54941...41ac104. Read the comment docs.

@dongahn
Copy link
Member

dongahn commented Jul 10, 2020

LGTM! Thank you for tackling this @chu11. I will add MWP label.

@dongahn dongahn added the merge-when-passing mergify.io - merge PR automatically once CI passes label Jul 10, 2020
@chu11
Copy link
Member Author

chu11 commented Jul 10, 2020

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2020

Command rebase: success

Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @chu11! Approving since @dongahn gave implied approval above.

@chu11
Copy link
Member Author

chu11 commented Jul 10, 2020

@dongahn I think you need to approve :-)

@mergify mergify bot merged commit be20512 into flux-framework:master Jul 10, 2020
@dongahn dongahn self-requested a review July 10, 2020 20:20
@chu11 chu11 deleted the fluxion_woke branch July 2, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mergify.io - merge PR automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use allowlist instead of whitelist
4 participants