solve portability issues for Ubuntu 17.10 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: liblsd/list.c fails to compile due to a new gcc7 "no-parentheses" warning. Add -Wno-parentheses to ignore this warning since liblsd was imported from another source.
Problem: rdl/lua-cpuset.c fails to compile due to a new gcc7 misleading-indentation error. The "problem" seems to come simply from inconsistent use of tabs vs spaces for indentation. Since expandtab is set in the modeline, just convert all tabs to spaces in that file.
Problem: gcc7 (i386) reports a mismatch between size_t values and PRIu64 printf format strings. Use %zd format for size_t.
Problem: 64-bit integer id is printed with %lu, causing gcc7 format error. Use PRId64 instead.
|
Nice cleanup @garlick! I will merge it once Travis turns green. BTW, this reminds me, at some point, I need to change the |
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
=======================================
Coverage 67.74% 67.74%
=======================================
Files 46 46
Lines 8692 8692
=======================================
Hits 5888 5888
Misses 2804 2804
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few minor fixes for issues that came up building sched on my i386 Ubuntu 17.10 test VM, which has gcc-7.2.0.
No issues with the native boost 1.62 on this system.