Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix mintime resource tree corruption bug #281

Merged
merged 2 commits into from
Nov 22, 2017
Merged

planner: fix mintime resource tree corruption bug #281

merged 2 commits into from
Nov 22, 2017

Conversation

dongahn
Copy link
Member

@dongahn dongahn commented Nov 19, 2017

  • Add a bug fix for a mintime resource tree corruption problem.
  • Add a test case.
  • This will be needed for upcoming resource-query test cases.

@dongahn
planner: fix mintime resource tree corruption bug
9f46d2f 
Fix a bug where the ending scheduled point of a span is
not removed from the mintime resource search tree.
W/ enough add, remove and add operation, this leads to SEGV.

Clean up the scheduled point reference-count code.
@dongahn
planner: Add a test for add followed by remove and add
5dbde50 
This is good enough to cause the prevision version to SEGV.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 77.788% when pulling 5dbde50 on dongahn:planner_bug_fix into e068c92 on flux-framework:master.

@codecov-io
Copy link

codecov-io commented Nov 19, 2017 •
edited
Loading

Codecov Report

Merging #281 into master will increase coverage by 0.53%.
The diff coverage is 98.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   74.92%   75.46%   +0.53%     
==========================================
  Files          34       34              
  Lines        7359     7419      +60     
==========================================
+ Hits         5514     5599      +85     
+ Misses       1845     1820      -25
Impacted Files Coverage Δ
resource/planner/test/planner_test01.cpp 100% <100%> (ø) ⬆️
resource/planner/planner.c 76.51% <90.9%> (+1.88%) ⬆️
src/common/librbtree/rbtree.c 81.71% <0%> (+7.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e068c92...5dbde50. Read the comment docs.

@dongahn dongahn mentioned this pull request Nov 19, 2017
Closed
@morrone morrone merged commit 9adf92e into flux-framework:master Nov 22, 2017
@dongahn
Copy link
Member Author

dongahn commented Nov 22, 2017

Thanks!

@grondo grondo mentioned this pull request May 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dongahn @coveralls @codecov-io @morrone