Bring in C++ configuration change to mirror flux-core #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the name of GCCWARN to WARNING_CFLAGS to eliminate the gcc-specificity from the name. Granted it is unlikely, but WARNING_CFLAGS might potentially have different values depending on the detected compiler, without requiring changes to each Makefile.am. The name is also now in keeping with our other *_CFLAGS named variables. Also, we change from @GCCWARN@ to the more common variable usage $(WARNING_CFLAGS). This will help a little bit with coming C++ flags.
Update ax_code_coverage.m4 to the latest from https://www.gnu.org/software/autoconf-archive/ax_code_coverage.html. This new version supports C++ with a CODE_COVERAGE_CXXFLAGS variable. Rename CODE_COVERAGE_LDFLAGS to CODE_COVERAGE_LIBS since the newer m4 file deprecates the former.
Introduce the WARNING_CXXFLAGS variable.
Introduce the AX_CXX_COMPILE_STDCXX macro from https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html. Employ the macro to set the C++ compiler to use C++11.
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 71.83% 72.17% +0.34%
==========================================
Files 29 29
Lines 5954 5862 -92
==========================================
- Hits 4277 4231 -46
+ Misses 1677 1631 -46
Continue to review full report at Codecov.
|
dongahn
reviewed
Sep 27, 2017
| @@ -1,5 +1,5 @@ | |||
| # =========================================================================== | |||
There was a problem hiding this comment.
This answers my other question in your jobspec PR!
|
Looks good to me. Merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch mirrors the changes that were made to flux-core in PR flux-framework/flux-core#1204.