Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t: update job.exception output checks #1315

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Dec 1, 2024

Problem: In the near future, the job.exception output in flux-core will change, resulting in failures in tests that expect a specific format.

Update the job.exception parsing in t1006-qmanager-multiqueue.t and t1024-alloc-check.t to be more flexible to future output changes.


in preparation for change in flux-framework/flux-core#6453

Problem: In the near future, the job.exception output in flux-core
will change, resulting in failures in tests that expect a specific
format.

Update the job.exception parsing in t1006-qmanager-multiqueue.t and
t1024-alloc-check.t to be more flexible to future output changes.
Copy link
Member

@trws trws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, is the plan to put something between these elements? Would it make more sense to grep for all of the tokens separately?

@chu11
Copy link
Member Author

chu11 commented Dec 2, 2024

Looks ok, is the plan to put something between these elements?

Yeah, the job id will go in between.

Would it make more sense to grep for all of the tokens separately?

Hmmm I guess could do that. But not sure worth the effort right now given it's such a minor change.

@chu11 chu11 added the merge-when-passing mergify.io - merge PR automatically once CI passes label Dec 2, 2024
@mergify mergify bot merged commit 6a7ecc0 into flux-framework:master Dec 2, 2024
21 checks passed
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.2%. Comparing base (aa4b89d) to head (6b75b7e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1315   +/-   ##
======================================
  Coverage    75.2%   75.2%           
======================================
  Files         111     111           
  Lines       15986   15986           
======================================
+ Hits        12028   12029    +1     
+ Misses       3958    3957    -1     

see 1 file with indirect coverage changes

@trws
Copy link
Member

trws commented Dec 2, 2024

That begs the question of why it isn't being added at the end, which would have left these unchanged. Is there a common format being mimicked?

@chu11
Copy link
Member Author

chu11 commented Dec 2, 2024

We had some back and forth on it here. flux-framework/flux-core#6453 I think there was just an opinion that it the jobid should be "earlier" in the output line, since that's what most people expect / want to see first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mergify.io - merge PR automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants