readers: allow id of -1 in JGF #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trws
approved these changes
Oct 7, 2024
jameshcorbett
added
the
merge-when-passing
Problem: if a vertex's ID is -1 in JGF, the reader will supply it with a default value. However, sometimes -1 is desired. Do not replace an ID of -1 with a default value when reading in JGF. Instead use -2 as the signpost that no ID was supplied.
jameshcorbett
force-pushed
the
t1035-id-fix
branch
from
62c011d to
d03405f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
======================================
Coverage 75.3% 75.3%
======================================
Files 111 111
Lines 15300 15300
======================================
Hits 11531 11531
Misses 3769 3769
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: if a vertex's ID is -1 in JGF, the reader will supply it with a default value. However, sometimes -1 is desired.
Do not replace an ID of -1 with a default value when reading in JGF. Instead use -2 as the signpost that no ID was supplied.
Fixes #1303