-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add descriptive warning about version #1294
Conversation
It works for me, there are two other options to set it:
in case you'd like to include those. |
2a2abcd
to
a1799a9
Compare
Put it at the top, since IMO that's the easiest way to fix it. New message:
|
Oh, grr, |
Looks good to me! Are you doing a similar one on core? |
Problem: flux-sched's version comes from `git describe`, which is passed to CMake. CMake validates versions using a regex in `CMake/Source/cmProjectCommand.cxx`. When this is an invalid version, flux-sched can't build. This often happens in CI, forks, or stripped-down user environments, and often happens to new contributors. Solution: Validate the version before passing to CMake. If the version is invalid, throw a descriptive warning with some suggestions. Fixes flux-framework#1291
a1799a9
to
1bcb014
Compare
@trws Sure am, made it easier once I realized the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1294 +/- ##
======================================
Coverage 75.3% 75.3%
======================================
Files 110 110
Lines 15236 15236
======================================
Hits 11486 11486
Misses 3750 3750 |
Problem: flux-sched's version comes from
git describe
, which is passed to CMake. CMake validates versions using a regex inCMake/Source/cmProjectCommand.cxx
. When this is an invalid version, flux-sched can't build. This often happens in CI, forks, or stripped-down user environments, and often happens to new contributors.Solution: Validate the version before passing to CMake. If the version is invalid, throw a descriptive warning with some suggestions.
Fixes #1291
This might be a little over-engineered, and suggestions about how to format the message are welcome.