Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: add build-matrix script to ease matching ci #1283

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

trws
Copy link
Member

@trws trws commented Aug 21, 2024

problem: we have good scripts for running in our images locally, but not always with all the same flags as in CI

solution: add a script, build-matrix, that takes a name from the actions build matrix and runs docker_run_checks with the same flags as that matrix entry

@trws trws requested a review from grondo August 21, 2024 17:53
Copy link
Member

@jameshcorbett jameshcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

scripts/build-matrix Outdated Show resolved Hide resolved
scripts/build-matrix Outdated Show resolved Hide resolved
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! I like that the script can also list the entries in the matrix.

problem: we have good scripts for running in our images locally, but not
always with all the same flags as in CI

solution: add a script, build-matrix, that takes a name from the actions
build matrix and runs docker_run_checks with the same flags as that
matrix entry
@trws
Copy link
Member Author

trws commented Aug 27, 2024

Thanks both of you, cleaned up a little bit and added it to the list to be processed by pre-commit so the style checks run on it.

@trws trws added the merge-when-passing mergify.io - merge PR automatically once CI passes label Aug 27, 2024
@mergify mergify bot merged commit f3efd73 into flux-framework:master Aug 27, 2024
19 checks passed
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (17b756c) to head (da1bbef).
Report is 70 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1283   +/-   ##
======================================
  Coverage    75.3%   75.3%           
======================================
  Files         111     111           
  Lines       15361   15361           
======================================
  Hits        11575   11575           
  Misses       3786    3786           
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mergify.io - merge PR automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants