deps: add install-deps.sh script, use in docker #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trws
force-pushed
the
refactor-install-deps
branch
4 times, most recently
from
a7ded95 to
34b36a8
Compare
jameshcorbett
approved these changes
Aug 21, 2024
trws
added
the
merge-when-passing
problem: we can't access scripts from docker builds with the current configuration solution: switch to the active directory being the source root and referencing the dockerfile with -f
problem: it's easy to accidentally miss adding or removing a dependency in the various dockerfiles and the readme solution: much like core, encode them as a script, then use it
trws
force-pushed
the
refactor-install-deps
branch
from
34b36a8 to
564d1f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1282 +/- ##
======================================
Coverage 75.3% 75.3%
======================================
Files 111 111
Lines 15361 15361
======================================
Hits 11575 11575
Misses 3786 3786
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: it's easy to accidentally miss adding or removing a dependency in the various dockerfiles and the readme
solution: much like core, encode them as a script, then use it
The main motivation for this is I noticed I missed some yesterday, even after @jameshcorbett's useful feedback on a few.