Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource: make feasibility service registration optional #1281

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

grondo
Copy link
Contributor

@grondo grondo commented Aug 20, 2024

Problem: There are many cases in the testsuite where the Fluxion resource module is loaded alongside sched-simple for testing, but this currently fails because these two modules now conflict due to the feasibility service.

Since feasibilty is an optional service, and may soon move to a separate module anyway, make feasibility service registration optional.

Problem: There are many cases in the testsuite where the Fluxion
resource module is loaded alongside sched-simple for testing, but
this currently fails because these two modules now conflict due to
the feasibility service.

Since feasibilty is an optional service, and may soon move to a
separate module anyway, make feasibility service registration optional.
@grondo grondo force-pushed the feasibility-no-error branch from 80e283c to d46d09d Compare August 21, 2024 00:02
@grondo
Copy link
Contributor Author

grondo commented Aug 21, 2024

Thanks! Setting MWP.

@grondo grondo added the merge-when-passing mergify.io - merge PR automatically once CI passes label Aug 21, 2024
@mergify mergify bot merged commit 0061ec0 into flux-framework:master Aug 21, 2024
20 of 21 checks passed
@grondo grondo deleted the feasibility-no-error branch August 21, 2024 00:17
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.4%. Comparing base (ca046b4) to head (d46d09d).
Report is 74 commits behind head on master.

Files with missing lines Patch % Lines
resource/modules/resource_match.cpp 50.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1281   +/-   ##
======================================
  Coverage    75.4%   75.4%           
======================================
  Files         111     111           
  Lines       15361   15360    -1     
======================================
  Hits        11588   11588           
+ Misses       3773    3772    -1     
Files with missing lines Coverage Δ
resource/modules/resource_match.cpp 68.8% <50.0%> (+<0.1%) ⬆️
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mergify.io - merge PR automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants