Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpine: use root to avoid nosuid issue in ci #1280

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

trws
Copy link
Member

@trws trws commented Aug 20, 2024

problem: just like with el9 and noble, alpine requires user to be set to root in the dockerfile here to build right under qemu-user-static in CI

solution: add the user root line where required

Another mistake that only shows up once we get into master, and this one only sometimes. 🤦

@trws trws requested a review from jameshcorbett August 20, 2024 21:22
problem: just like with el9 and noble, alpine requires user to be set to
root in the dockerfile here to build right under qemu-user-static in CI

solution: add the user root line where required
Copy link
Member

@jameshcorbett jameshcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trws trws merged commit 95899f6 into flux-framework:master Aug 20, 2024
17 checks passed
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.4%. Comparing base (37215cf) to head (20d1f60).
Report is 80 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1280   +/-   ##
======================================
  Coverage    75.4%   75.4%           
======================================
  Files         111     111           
  Lines       15359   15359           
======================================
  Hits        11588   11588           
  Misses       3771    3771           
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants