testsuite: fix a couple race conditions in t4011-match-duration.t
#1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: It may be useful to log when an instance expiration update occurs, but the resource module does not do that. Add a log message on expiration update.
Problem: Sometimes it is useful during testing to wait for a given pattern to appear in the Flux dmesg logs, but waiting for a matching line to appear in `flux-dmesg(1)` output using the shell is brittle and inconvenient. Copy the dmesg-grep.py script from flux-core for this purpose.
Problem: There are two potential race conditions in the final test in t4011-match-duration.t which ensures the internal expiration of the scheduler resource is adjusted after an expiration update. 1. A check for the default duration of a submitted job assumes the duration will be strictly less than the instance duration, but if the job starts within the same second as the instance starttime then the duration could match exactly the instance duration since Fluxion deals in whole seconds. 2. The scheduler is notified of the expiration update asynchronously with respect to the instance update, which is detected in the test via the resource-update event in the resource.eventlog. This could result in the second submitted job receiving an unexpected default duration. Fix case 1 above by allowing the job duration to match (but not exceed) the instance duration. Fix case 2 by blocking the test until the scheduler emits a log message for the duration update.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1109 +/- ##
======================================
Coverage 71.8% 71.8%
======================================
Files 88 88
Lines 11530 11531 +1
======================================
+ Hits 8286 8287 +1
Misses 3244 3244
|
|
Thanks @jameshcorbett! I had to restart the spelling and pr-validator checks because they failed for unknown reason. I'll set MWP now. |
grondo
added
the
merge-when-passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple race conditions in
t/t4011-match-duration.twhich cause the test to fail occasionally.