ci: fix coverage build #1106
Merged
ci: fix coverage build #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: It appears that the coverage check commands return a nonzero exit status even when `make check-code-coverage` succeeds, and therefore `make recheck` is unnecessarily executed. The failure appears to be in one of the post-check steps, which are possibly duplicated from the cmake version of `make check-code-coverage`. In any event, remove 'coverage html' (which probably isn't useful anyway), and make success of `coverage xml` and `coverage report` optional.
|
Thanks! I'll set MWP. |
grondo
added
the
merge-when-passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
coveragebuild is always reportingWarning: make check failed, trying recheck in ./t. Apparently, this isn't becausemake check-code-coverageis failing, but because one of the subsequentcoverage blahsteps is.Possibly some change in the cmake
check-code-coveragetarget is causing one of these steps to fail, or maybe it was always like this for flux-sched. Anyway, this PR just removes some of the post-check coverage steps and makes a couple others optional to avoid the extra unnecessary work ofmake recheck.